linux-kernel - Re: [PATCH] memory: ti-aemif: Drop child node when jumping out loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210125192017.l3w7hd5ntnqp4gyr@kozik-lap>
Date:   Mon, 25 Jan 2021 20:20:17 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Pan Bian <bianpan2016@....com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: ti-aemif: Drop child node when jumping out loop

On Thu, Jan 21, 2021 at 01:03:59AM -0800, Pan Bian wrote:
> Call of_node_put() to decrement the reference count of the child node
> child_np when jumping out of the loop body of
> for_each_available_child_of_node(), which is a macro that increments and
> decrements the reference count of child node. If the loop is broken, the
> reference of the child node should be dropped manually.
> 
> Fixes: 5a7c81547c1d ("memory: ti-aemif: introduce AEMIF driver")
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/memory/ti-aemif.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Thanks, applied.

Best regards,
Krzysztof