linux-kernel - Re: [PATCH v2 29/34] Intel tsens i2c slave driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0V5wFYypYDXbVFQvzbjL5K0Gp0j+Zfg_7-5vML1B1-Cg@mail.gmail.com>
Date:   Tue, 26 Jan 2021 08:45:05 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     mgross@...ux.intel.com
Cc:     Randy Dunlap <rdunlap@...radead.org>, markgross@...nel.org,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...e.de>,
        Damien Le Moal <damien.lemoal@....com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        gregkh <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Leonard Crestez <leonard.crestez@....com>,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Peng Fan <peng.fan@....com>, Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "C, Udhayakumar" <udhayakumar.c@...el.com>, C@...ux.intel.com
Subject: Re: [PATCH v2 29/34] Intel tsens i2c slave driver.

On Tue, Jan 26, 2021 at 12:39 AM mark gross <mgross@...ux.intel.com> wrote:
>
> On Mon, Jan 11, 2021 at 11:15:06PM -0800, Randy Dunlap wrote:
> > On 1/8/21 1:25 PM, mgross@...ux.intel.com wrote:
> > > diff --git a/drivers/misc/intel_tsens/Kconfig b/drivers/misc/intel_tsens/Kconfig
> > > index 8b263fdd80c3..c2138339bd89 100644
> > > --- a/drivers/misc/intel_tsens/Kconfig
> > > +++ b/drivers/misc/intel_tsens/Kconfig
> > > @@ -14,6 +14,20 @@ config INTEL_TSENS_LOCAL_HOST
> > >       Say Y if using a processor that includes the Intel VPU such as
> > >       Keem Bay.  If unsure, say N.
> > >
> > > +config INTEL_TSENS_I2C_SLAVE
> > > +   bool "I2C slave driver for intel tsens"
> >
> > Why bool instead of tristate?
> Becuase the I2C driver depends on a file scoped global i2c_plat_data
> instanciated in the INTELL_TSENS_LOCAL_HOST DRIVER (intel_tsens_thermal.[ch])
>
> Udhaya, would you care to comment further?

> > > +   depends on INTEL_TSENS_LOCAL_HOST
> > > +   select I2C
> > > +   select I2C_SLAVE

Please make this 'depends on I2C=y && I2C_SLAVE' instead of 'select'
in this case. A random driver should never force-enable another subsystem.

      Arnd