linux-kernel - [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1611684201-16262-1-git-send-email-george.kennedy@oracle.com>
Date:   Tue, 26 Jan 2021 13:03:21 -0500
From:   George Kennedy <george.kennedy@...cle.com>
To:     george.kennedy@...cle.com, pjones@...hat.com, konrad@...nel.org,
        linux-kernel@...r.kernel.org, konrad.wilk@...cle.com
Subject: [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft_init()

During boot of kernel with CONFIG_KASAN the following KASAN false
positive failure will occur when ibft_init() reads the
ACPI iBFT table: BUG: KASAN: use-after-free in ibft_init

The ACPI iBFT table is not allocated, and the iscsi driver uses
a pointer to it to calculate checksum, etc. KASAN complains
about this pointer with use-after-free, which this is not.

Signed-off-by: George Kennedy <george.kennedy@...cle.com>
---
 drivers/firmware/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
index 5e013b6..30ddab5 100644
--- a/drivers/firmware/Makefile
+++ b/drivers/firmware/Makefile
@@ -14,6 +14,9 @@ obj-$(CONFIG_INTEL_STRATIX10_SERVICE) += stratix10-svc.o
 obj-$(CONFIG_INTEL_STRATIX10_RSU)     += stratix10-rsu.o
 obj-$(CONFIG_ISCSI_IBFT_FIND)	+= iscsi_ibft_find.o
 obj-$(CONFIG_ISCSI_IBFT)	+= iscsi_ibft.o
+KASAN_SANITIZE_iscsi_ibft.o := n
+KCOV_INSTRUMENT_iscsi_ibft.o := n
+
 obj-$(CONFIG_FIRMWARE_MEMMAP)	+= memmap.o
 obj-$(CONFIG_RASPBERRYPI_FIRMWARE) += raspberrypi.o
 obj-$(CONFIG_FW_CFG_SYSFS)	+= qemu_fw_cfg.o
-- 
1.8.3.1