linux-kernel - Re: [PATCH v3 2/6] ALSA: hda/tegra: Reset hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5him7k2omh.wl-tiwai@suse.de>
Date:   Tue, 26 Jan 2021 07:33:58 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Sameer Pujar <spujar@...dia.com>,
        Peter Geis <pgwipeout@...il.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/6] ALSA: hda/tegra: Reset hardware

On Mon, 25 Jan 2021 16:27:30 +0100,
Dmitry Osipenko wrote:
> 
> 25.01.2021 18:18, Takashi Iwai пишет:
> > On Wed, 20 Jan 2021 01:31:50 +0100,
> > Dmitry Osipenko wrote:
> >>
> >> Reset hardware on RPM-resume in order to bring it into a predictable
> >> state.
> >>
> >> Tested-by: Peter Geis <pgwipeout@...il.com> # Ouya T30 audio works
> >> Tested-by: Matt Merhar <mattmerhar@...tonmail.com> # Ouya T30 boot-tested
> >> Tested-by: Nicolas Chauvet <kwizart@...il.com> # TK1 boot-tested
> >> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> > 
> > Currently we have neither dependency nor reverse-selection of
> > CONFIG_RESET_CONTROLLER.  It wouldn't be a problem for builds, but
> > you'll get a runtime error from
> > devm_reset_control_array_get_exclusive() always when
> > CONFIG_RESET_CONTROLLER=n.
> > 
> > I guess it must be a corner case, but just to be sure.
> 
> The CONFIG_RESET_CONTROLLER=y at least for ARM32 Tegra builds.
> 
> https://elixir.bootlin.com/linux/v5.11-rc5/source/arch/arm/mach-tegra/Kconfig#L15
> 
> Not sure about ARM64.

OK, then it must be fine.
I applied now.  Thanks.


Takashi