linux-kernel - Re: [PATCH v2 2/3] media/radio: Make radio_isa_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 10:51:03 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] media/radio: Make radio_isa_common_remove() return
 void

On 22/01/2021 10:24, Uwe Kleine-König wrote:
> Instead of an unconditional return 0, return no value. One of the two
> callers ignored the return value already before.
> 
> This simplifies the next patch.
> 
> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>

Reviewed-by: Hans Verkuil <hverkuil-cisco@...all.nl>

Thanks!

	Hans

> ---
>  drivers/media/radio/radio-isa.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c
> index ad2ac16ff12d..527f4c3b0ca4 100644
> --- a/drivers/media/radio/radio-isa.c
> +++ b/drivers/media/radio/radio-isa.c
> @@ -273,8 +273,8 @@ static int radio_isa_common_probe(struct radio_isa_card *isa,
>  	return res;
>  }
>  
> -static int radio_isa_common_remove(struct radio_isa_card *isa,
> -				   unsigned region_size)
> +static void radio_isa_common_remove(struct radio_isa_card *isa,
> +				    unsigned region_size)
>  {
>  	const struct radio_isa_ops *ops = isa->drv->ops;
>  
> @@ -285,7 +285,6 @@ static int radio_isa_common_remove(struct radio_isa_card *isa,
>  	release_region(isa->io, region_size);
>  	v4l2_info(&isa->v4l2_dev, "Removed radio card %s\n", isa->drv->card);
>  	kfree(isa);
> -	return 0;
>  }
>  
>  int radio_isa_probe(struct device *pdev, unsigned int dev)
> @@ -342,7 +341,9 @@ int radio_isa_remove(struct device *pdev, unsigned int dev)
>  {
>  	struct radio_isa_card *isa = dev_get_drvdata(pdev);
>  
> -	return radio_isa_common_remove(isa, isa->drv->region_size);
> +	radio_isa_common_remove(isa, isa->drv->region_size);
> +
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(radio_isa_remove);
>  
>