linux-kernel - Re: [PATCH v3] Bluetooth: btrtl: Enable WBS for the specific Realtek devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <675B3B14-76DB-4748-811C-AA98848EA30E@holtmann.org>
Date:   Mon, 25 Jan 2021 16:10:25 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Max Chou <max.chou@...ltek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        alex_lu@...lsil.com.cn, hildawu@...ltek.com, kidman@...ltek.com,
        abhishekpandit@...omium.org, josephsih@...omium.org
Subject: Re: [PATCH v3] Bluetooth: btrtl: Enable WBS for the specific Realtek
 devices

Hi Max,

> By this change, it will enable WBS supported on the specific Realtek BT
> devices, such as RTL8822C and RTL8852A.
> In the future, it's able to maintain what the Realtek devices support WBS
> here.
> 
> Tested-by: Hilda Wu <hildawu@...ltek.com>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> Signed-off-by: Max Chou <max.chou@...ltek.com>
> 
> ---
> change in v3
> -remove the null check due to unnecessary
> ---
> drivers/bluetooth/btrtl.c | 29 +++++++++++++++++++++++------
> 1 file changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 24f03a1f8d57..a21d6abc93c4 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -38,6 +38,19 @@
> 	.hci_ver = (hciv), \
> 	.hci_bus = (bus)
> 
> +enum  btrtl_chip_id {

remove the extra space here.

> +	CHIP_ID_8723A,		/* index  0 for RTL8723A*/
> +	CHIP_ID_8723B,		/* index  1 for RTL8723B*/
> +	CHIP_ID_8821A,		/* index  2 for RTL8821A*/
> +	CHIP_ID_8761A,		/* index  3 for RTL8761A*/
> +	CHIP_ID_8822B = 8,	/* index  8 for RTL8822B */
> +	CHIP_ID_8723D,		/* index  9 for RTL8723D */
> +	CHIP_ID_8821C,		/* index 10 for RTL8821C */
> +	CHIP_ID_8822C = 13,	/* index 13 for RTL8822C */
> +	CHIP_ID_8761B,		/* index 14 for RTL8761B */
> +	CHIP_ID_8852A = 18,	/* index 18 for RTL8852A */
> +};
> +
> struct id_table {
> 	__u16 match_flags;
> 	__u16 lmp_subver;
> @@ -58,6 +71,7 @@ struct btrtl_device_info {
> 	u8 *cfg_data;
> 	int cfg_len;
> 	bool drop_fw;
> +	int project_id;
> };
> 
> static const struct id_table ic_id_table[] = {
> @@ -307,8 +321,10 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
> 
> 	/* Find project_id in table */
> 	for (i = 0; i < ARRAY_SIZE(project_id_to_lmp_subver); i++) {
> -		if (project_id == project_id_to_lmp_subver[i].id)
> +		if (project_id == project_id_to_lmp_subver[i].id) {
> +			btrtl_dev->project_id = project_id;
> 			break;
> +		}
> 	}
> 
> 	if (i >= ARRAY_SIZE(project_id_to_lmp_subver)) {
> @@ -719,18 +735,19 @@ int btrtl_setup_realtek(struct hci_dev *hdev)
> 	 */
> 	set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
> 
> -	if (!btrtl_dev->ic_info)
> -		goto done;
> -
> 	/* Enable central-peripheral role (able to create new connections with
> 	 * an existing connection in slave role).
> 	 */
> -	switch (btrtl_dev->ic_info->lmp_subver) {
> -	case RTL_ROM_LMP_8822B:
> +	/* Enable WBS supported for the specific Realtek devices. */
> +	switch (btrtl_dev->project_id) {
> +	case CHIP_ID_8822C:
> +	case CHIP_ID_8852A:
> 		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
> +		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
> 		break;
> 	default:
> 		rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
> +		rtl_dev_dbg(hdev, "WBS supported not enabled.");
> 		break;
> 	}

Regards

Marcel