linux-kernel - Re: [PATCH v4 00/17] Miscellaneous fixes for resctrl selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9df84c6a-3113-1f3d-5e61-cd68bc6f2d62@linuxfoundation.org>
Date:   Mon, 25 Jan 2021 18:22:19 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Fenghua Yu <fenghua.yu@...el.com>, Shuah Khan <shuah@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        David Binderman <dcb314@...mail.com>,
        Babu Moger <babu.moger@....com>,
        James Morse <james.morse@....com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/17] Miscellaneous fixes for resctrl selftests

On 11/30/20 1:19 PM, Fenghua Yu wrote:
> This patch set has several miscellaneous fixes to resctrl selftest tool
> that are easily visible to user. V1 had fixes to CAT test and CMT test
> but they were dropped in V2 because having them here made the patchset
> humongous. So, changes to CAT test and CMT test will be posted in another
> patchset.
> 
> Change Log:
> v4:
> - Address various comments from Shuah Khan:
>    1. Combine a few patches e.g. a couple of fixing typos patches into one
>       and a couple of unmounting patches into one etc.
>    2. Add config file.
>    3. Remove "Fixes" tags.
>    4. Change strcmp() to strncmp().
>    5. Move the global variable fixing patch to the patch 1 so that the
>       compilation issue is fixed first.
> 

Sorry for the delay. Please cc linux-kselftest in your next version.
I have a few comments on the patches.

thanks,
-- Shuah