linux-kernel - Re: [PATCH v10 2/4] arm64: dts: mt8183: Add node for the Mali GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANMq1KCdCurhB0S_a4qRtNbOUWMZa9=ObZkz0VSGLgCnfV-k9Q@mail.gmail.com>
Date:   Tue, 26 Jan 2021 09:03:10 +0800
From:   Nicolas Boichat <drinkcat@...omium.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Steven Price <steven.price@....com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Fei Shao <fshao@...omium.org>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Kristian Kristensen <hoegsberg@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Devicetree List <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v10 2/4] arm64: dts: mt8183: Add node for the Mali GPU

On Tue, Jan 26, 2021 at 3:27 AM Rob Herring <robh@...nel.org> wrote:
>
[...]
> > +&gpu {
> > +     supply-names = "mali", "sram";
>
> Not a documented property, nor should it be.
>
> Did you run this against dtbs_check with your schema changes?

I did not, for some reasons I hit a strange issue (kernel build system
wouldn't pick up dt-* tools from ~/.local/bin... solved with a bunch
of symlinks to ~/bin). Gave up too quickly ,-(

Anyway, v11 coming with clean make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml.

>
> > +     mali-supply = <&mt6358_vgpu_reg>;
> > +     sram-supply = <&mt6358_vsram_gpu_reg>;
> > +};
> > +
> >  &i2c0 {
> >       pinctrl-names = "default";
> >       pinctrl-0 = <&i2c_pins_0>;