linux-kernel - Re: [PATCH] mm/filemap: Remove redundant variable's assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59c68a70-4938-709c-77f4-2a2aea5e269d@linux.alibaba.com>
Date:   Tue, 26 Jan 2021 10:03:29 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/filemap: Remove redundant variable's assignment



在 2021/1/26 7:22, Andrew Morton 写道:
> On Mon, 25 Jan 2021 11:20:02 +0800 Baolin Wang <baolin.wang@...ux.alibaba.com> wrote:
> 
>> We've already set the variable 'i' 's initial value before using it,
>> thus remove redundant previous assignment of variable 'i'.
>>
>> ...
>>
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
>>   		if ((iocb->ki_flags & IOCB_WAITQ) && written)
>>   			iocb->ki_flags |= IOCB_NOWAIT;
>>   
>> -		i = 0;
>>   		pg_nr = generic_file_buffered_read_get_pages(iocb, iter,
>>   							     pages, nr_pages);
>>   		if (pg_nr < 0) {
> 
> Matthew's patch series "Refactor generic_file_buffered_read "
> (https://lkml.kernel.org/r/20210122160140.223228-1-willy@infradead.org)
> changes all this code - I dont think the patch is relevant after that,
> so I'll skip it.

Ah, right. Thanks for letting me know.