linux-kernel - Re: [PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f4a47f8-18dc-cb73-10db-033e5e5adb25@ti.com>
Date:   Mon, 25 Jan 2021 18:16:38 -0600
From:   Suman Anna <s-anna@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Marc Zyngier <maz@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Nishanth Menon <nm@...com>, Lokesh Vutla <lokeshvutla@...com>,
        Sekhar Nori <nsekhar@...com>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        David Lechner <david@...hnology.com>,
        <devicetree@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
Subject: Re: [PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC

Hi Rob,

On 1/25/21 6:04 PM, Rob Herring wrote:
> On Fri, Jan 15, 2021 at 02:58:19PM -0600, Suman Anna wrote:
>> The '#address-cells' property looks to be a required property for
>> interrupt controller nodes as indicated by a warning message seen
>> when building dtbs with W=2. Adding the property to the PRUSS INTC
>> dts nodes though fails the dtbs_check. Add this property to the
>> PRUSS INTC binding to make it compliant with both dtbs_check and
>> building dtbs.
>>
>> Signed-off-by: Suman Anna <s-anna@...com>
>> ---
>> Hi Rob,
>>
>> This patch is also part of our effort to get rid of the warnings seen
>> around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS
>> INTC bindings to not get a warning with dtbs_check while also ensuring
>> no warnings while building dtbs with W=2.
>>
>> I would have expected the '#address-cells' requirement to be inherited
>> automatically. And looking through the schema files, I actually do not
>> see the interrupt-controller.yaml included automatically anywhere. You
>> had asked us to drop the inclusion in this binding in our first version
>> with YAML [3]. Am I missing something, and how do we ensure that this
>> is enforced automatically for everyone?
> 
> interrupt-controller.yaml is applied to any node named 
> 'interrupt-controller'. More generally, if 'compatible' is not present, 
> then we look at $nodename for the default 'select'. In your case, you 
> didn't name the node appropriately.

Thanks for the clarification. Yeah, I didn't add anything specifically, since
the expectation is interrupt-controller. Should I be adding that to this binding?

>  
> We can't check this in interrupt-controller.yaml because #address-cells 
> is not always 0. GICv3 is one notable exception.
> 
>>
>> regards
>> Suman
>>
>> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/
> 
> I've commented on this thread now in regards to #address-cells.

I suppose I still need this patch to be defined to unblock the ICSSG nodes
getting accepted by our dts maintainer. Care to give your Reviewed-by for the
change? Or I can spin a v2 with $nodename added as well if that's needed too.

regards
Suman

> 
> Rob
> 
>> [2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/
>> [3] https://patchwork.kernel.org/comment/23484523/
>>
>>  .../bindings/interrupt-controller/ti,pruss-intc.yaml        | 6 ++++++
>>  1 file changed, 6 insertions(+)