linux-kernel - Re: [PATCH 27/32] NFS: Refactor nfs_readpage() and nfs_readpage_async() to use nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210126040540.GK308988@casper.infradead.org>
Date:   Tue, 26 Jan 2021 04:05:40 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Trond Myklebust <trondmy@...merspace.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        Steve French <sfrench@...ba.org>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Dave Wysochanski <dwysocha@...hat.com>,
        Jeff Layton <jlayton@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-cachefs@...hat.com, linux-afs@...ts.infradead.org,
        linux-nfs@...r.kernel.org, linux-cifs@...r.kernel.org,
        ceph-devel@...r.kernel.org, v9fs-developer@...ts.sourceforge.net,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 27/32] NFS: Refactor nfs_readpage() and
 nfs_readpage_async() to use nfs_readdesc

On Mon, Jan 25, 2021 at 09:36:13PM +0000, David Howells wrote:
> +int nfs_readpage_async(void *data, struct inode *inode,
>  		       struct page *page)
>  {
> +	struct nfs_readdesc *desc = (struct nfs_readdesc *)data;

You don't need a cast to cast from void.

> @@ -440,17 +439,16 @@ int nfs_readpages(struct file *filp, struct address_space *mapping,
>  	if (ret == 0)
>  		goto read_complete; /* all pages were read */
>  
> -	desc.pgio = &pgio;
> -	nfs_pageio_init_read(&pgio, inode, false,
> +	nfs_pageio_init_read(&desc.pgio, inode, false,

I like what you've done here, embedding the pgio in the desc.