linux-kernel - Re: [PATCH] arm: smp: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210126104155.GF1551@shell.armlinux.org.uk>
Date:   Tue, 26 Jan 2021 10:41:55 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm: smp: remove unused variable

On Tue, Jan 26, 2021 at 11:04:47AM +0100, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Mon, Dec 28, 2020 at 1:03 PM Wolfram Sang
> <wsa+renesas@...g-engineering.com> wrote:
> > Not used anymore after refactoring:
> >
> > arch/arm/kernel/smp.c: In function ‘show_ipi_list’:
> > arch/arm/kernel/smp.c:543:16: warning: variable ‘irq’ set but not used [-Wunused-but-set-variable]
> >   543 |   unsigned int irq;
> >
> > Fixes: 88c637748e31 ("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()")
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Marc Zyngier <maz@...nel.org>
> 
> Known issue since Dec 15, and still not fixed...
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Those who cause breakage really should be the ones to look at patches
that fix their breakage.

The way patches get applied is if they end up in my patch system... if
they don't make it there, they don't get applied.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!