linux-kernel - RE: [PATCH] lkdtm: fix memory copy size for WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b48470af3b841e4bd8ba15a4ee5e745@AcuMS.aculab.com>
Date:   Tue, 26 Jan 2021 22:53:31 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Nick Desaulniers' <ndesaulniers@...gle.com>,
        Candle Sun <candlesea@...il.com>
CC:     "keescook@...omium.org" <keescook@...omium.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "natechancellor@...il.com" <natechancellor@...il.com>,
        "candle.sun@...soc.com" <candle.sun@...soc.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>
Subject: RE: [PATCH] lkdtm: fix memory copy size for WRITE_KERN

From: Nick Desaulniers
> Sent: 26 January 2021 18:40
> 
> On Tue, Jan 26, 2021 at 6:13 AM Candle Sun <candlesea@...il.com> wrote:
> >
> > On Mon, Jan 25, 2021 at 6:37 PM David Laight <David.Laight@...lab.com> wrote:
> > >
> > > From: Candle Sun
> > > > Sent: 25 January 2021 08:56
> > > >
> > > > From: Candle Sun <candle.sun@...soc.com>
> > > >
> > > > Though do_overwritten() follows do_nothing() in source code, the final
> > > > memory address order is determined by compiler. We can't always assume
> > > > address of do_overwritten() is bigger than do_nothing(). At least the
> > > > Clang we are using places do_overwritten() before do_nothing() in the
> > > > object. This causes the copy size in lkdtm_WRITE_KERN() is *really*
> > > > big and WRITE_KERN test on ARM32 arch will fail.
> > > >
> > > > Compare the address order before doing the subtraction.
> > >
> > > It isn't clear that helps.
> > > Compile with -ffunction-sections and/or do LTO an there
> > > is no reason at all why the functions should be together.
> > >
> > > Even without that lkdtm_WRITE_KERN() could easily be between them.
> > >
> > > You need to get the size of the 'empty function' from the
> > > symbol table.
> > >
> > >         David
> >
> > Thanks David.
> >
> > I think using abs() by Nick's advice would be better. But could you
> > point out which kernel function can get function size?
> 
> The Elf symbol table should contain this info, IIUC.
> 
> Given a string literal of a symbol (such as a function identifier),
> kallsyms_lookup_name() can be used to return its address.
> 
> From there we'd want to fetch the Elf_Sym for the address which should
> contain a st_size field which I think corresponds to the size in bytes
> of the function.  (At least, from playing with `llvm-readelf -s`)
> Probably would want to validate it's an STT_FUNC symbol type, too.  We
> basically want something like kexec_purgatory_find_symbol(), but that
> knows about the entire kernel image, and not the purgatory image used
> during kexec.  I don't see any such function currently in the
> kernel...but it's a large codebase to search through.

The alternative is to get the linker script to define a specific
constant to the size of the function.
You can then link against it (by using it as the address of a symbol).

It may be easier to use an asm file for the 'return 0' code.
I'm guessing there are things in the static branch area
that could be used.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)