linux-kernel - RE: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB3873034EAC12E956E6879967B0BB9@CO6PR18MB3873.namprd18.prod.outlook.com>
Date:   Wed, 27 Jan 2021 14:37:34 +0000
From:   Stefan Chulski <stefanc@...vell.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Nadav Haklai <nadavh@...vell.com>,
        Yan Markman <ymarkman@...vell.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "mw@...ihalf.com" <mw@...ihalf.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "atenart@...nel.org" <atenart@...nel.org>
Subject: RE: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC
 firmware check


> -----Original Message-----
> From: Russell King - ARM Linux admin <linux@...linux.org.uk>
> Sent: Wednesday, January 27, 2021 4:06 PM
> To: Stefan Chulski <stefanc@...vell.com>
> Cc: netdev@...r.kernel.org; thomas.petazzoni@...tlin.com;
> davem@...emloft.net; Nadav Haklai <nadavh@...vell.com>; Yan
> Markman <ymarkman@...vell.com>; linux-kernel@...r.kernel.org;
> kuba@...nel.org; mw@...ihalf.com; andrew@...n.ch;
> atenart@...nel.org
> Subject: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC
> firmware check
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, Jan 27, 2021 at 01:43:35PM +0200, stefanc@...vell.com wrote:
> >  	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
> > -		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
> > -		val |= FLOW_CONTROL_ENABLE_BIT;
> > -		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
> > +		err = mvpp2_enable_global_fc(priv);
> > +		if (err) {
> > +			dev_warn(&pdev->dev, "CM3 firmware not running,
> version should be higher than 18.09\n");
> > +			dev_warn(&pdev->dev, "Flow control not
> supported\n");
> > +		}
> 
> I've just booted this on my mcbin-ss, and I get:
> 
> mvpp2 f2000000.ethernet: CM3 firmware not running, version should be
> higher than 18.09
> mvpp2 f4000000.ethernet: CM3 firmware not running, version should be
> higher than 18.09
> 
> which is rather odd, because I believe I'm running the 18.12 firmware from
> git://github.com/MarvellEmbeddedProcessors/binaries-marvell
> branch binaries-marvell-armada-18.12.
> 
> Any ideas?

Your mcbin-ss is A8K AX or A8K B0? On AX revisions we do not have FC support in firmware.

Regards.