linux-kernel - Re: [PATCH] bcache: dont reset bio opf in bch_data_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210127173726.GA1738577@infradead.org>
Date:   Wed, 27 Jan 2021 17:37:26 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Dongsheng Yang <dongsheng.yang@...ystack.cn>
Cc:     colyli@...e.de, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org, mchristi@...hat.com
Subject: Re: [PATCH] bcache: dont reset bio opf in bch_data_insert_start

But the old code is also completely broken.  We can't just OR in
the op, as that implicitly assumes the old op was 0 (REQ_OP_READ).

Please fix this to explicitly set the exact op and flags that you want
instead of this fragile magic.