linux-kernel - Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Jan 2021 12:39:36 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     stefanc@...vell.com
Cc:     Network Development <netdev@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        David Miller <davem@...emloft.net>, nadavh@...vell.com,
        ymarkman@...vell.com, LKML <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>, linux@...linux.org.uk,
        mw@...ihalf.com, Andrew Lunn <andrew@...n.ch>,
        rmk+kernel@...linux.org.uk, Antoine Tenart <atenart@...nel.org>
Subject: Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA
 configuration path

On Wed, Jan 27, 2021 at 7:19 AM <stefanc@...vell.com> wrote:
>
> From: Stefan Chulski <stefanc@...vell.com>
>
> Spinlock added to MSS shared memory configuration space.
>
> Signed-off-by: Stefan Chulski <stefanc@...vell.com>
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2.h      | 5 +++++
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++
>  2 files changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> index 9d8993f..f34e260 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> @@ -1021,6 +1021,11 @@ struct mvpp2 {
>
>         /* CM3 SRAM pool */
>         struct gen_pool *sram_pool;
> +
> +       bool custom_dma_mask;
> +
> +       /* Spinlocks for CM3 shared memory configuration */
> +       spinlock_t mss_spinlock;

Does this need to be a stand-alone patch? This introduces a spinlock,
but does not use it.

Also, is the introduction of custom_dma_mask in this commit on purpose?