lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jan 2021 10:21:30 -0800 From: Joe Perches <joe@...ches.com> To: Dan Carpenter <dan.carpenter@...cle.com>, Greg KH <gregkh@...uxfoundation.org> Cc: carlis <zhangxuezhi3@...il.com>, Andy Whitcroft <apw@...onical.com>, devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org, mh12gx2825@...il.com, oliver.graute@...oconnector.com, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, sbrivio@...hat.com, colin.king@...onical.com, zhangxuezhi1@...ong.com Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect > Comments are the exception to the "no spaces at the start of a line" > rule. I was expecting that the kbuild-bot would send a Smatch warning > for inconsistent indenting, but comments are not counted there either. > > I'm sort of surprised that we don't have checkpatch rule about the > missing space characters. It should be: "/* Tearing Effect Line On */". Maybe this but the "preceded by a tab" test is pretty noisy. --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4f8494527139..72347e82d384 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3720,6 +3720,22 @@ sub process { s/(\(\s*$Type\s*\))[ \t]+/$1/; } } + +# Comment styles +# Initial comment only lines that have a leading space + if ($rawline =~ m{^\+([ \t]+)(?:/\*|//)} && $1 =~ / /) { + WARN("COMMENT_STYLE", + "Initial comment lines should be indented only with tabs\n" . $herecurr); +# comments not aligned on tabs + } elsif ($rawline !~ m{^\+(?:/\*|//)} && + $rawline =~ m{^\+.*[^\t](?:/\*|//)}) { + CHK("COMMENT_STYLE", + "Comments should generally be preceded by a tab\n" . $herecurr); + } + +# comment initiators should generally be followed by a space if using words + if ($rawline =~ m{^\+.*(?:/\*|//)\w}) { + WARN("COMMENT_STYLE", + "Comment text should use a space after the comment initiator\n" . $herecurr); + } # Block comment styles # Networking with an initial /*
Powered by blists - more mailing lists