linux-kernel - Re: [PATCH] thermal: qcom: tsens-v0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e08f75be-4520-395d-599b-a2cbd7fbefe8@somainline.org>
Date:   Wed, 27 Jan 2021 19:44:16 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        Amit Kucheria <amitk@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: qcom: tsens-v0_1: Add support for MDM9607


> Afaict, there's no need to initialize base0 and base1, they are both
> assigned to before used.
>
> Also, they are temporary variables within each case (even with the
> fallthrough), so you should only need a single "base".
>
Right. Fixed, will send in a v3 (I sent a v2 shortly after this one because I misplaced the #defines).


> How about:
>
> 	mode = field_get(MDM9607_CAL_SEL_MASK, qfprom_cdata[2]);
>
> and same below.
>
> (I see that this would break the style of the file, perhaps we can clean
> that up?)
>
I'd rather not change that to keep it comparable to the downstream driver, should anything ever break and need investigation..


> qfprom_csel seems unused and uninitialized.

Fixed as well.


Konrad