linux-kernel - Re: [Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-+cHaOjHDXfQx2b+N14V-DfQdiC7EPcRKwXzGVdWbm89A@mail.gmail.com>
Date:   Wed, 27 Jan 2021 15:33:35 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Hariprasad Kelam <hkelam@...vell.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob <jerinj@...vell.com>, sbhatta@...vell.com,
        Christina Jacob <cjacob@...vell.com>
Subject: Re: [Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

On Wed, Jan 27, 2021 at 4:02 AM Hariprasad Kelam <hkelam@...vell.com> wrote:
>
> From: Christina Jacob <cjacob@...vell.com>
>
> CGX LMAC, the physical interface support link configuration parameters
> like speed, auto negotiation, duplex  etc. Firmware saves these into
> memory region shared between firmware and this driver.
>
> This patch adds mailbox handler set_link_mode, fw_data_get to
> configure and read these parameters.
>
> Signed-off-by: Christina Jacob <cjacob@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>

> +int rvu_mbox_handler_cgx_set_link_mode(struct rvu *rvu,
> +                                      struct cgx_set_link_mode_req *req,
> +                                      struct cgx_set_link_mode_rsp *rsp)
> +{
> +       int pf = rvu_get_pf(req->hdr.pcifunc);
> +       u8 cgx_idx, lmac;
> +       void *cgxd;
> +
> +       if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc))
> +               return -EPERM;
> +
> +       rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_idx, &lmac);
> +       cgxd = rvu_cgx_pdata(cgx_idx, rvu);
> +       rsp->status =  cgx_set_link_mode(cgxd, req->args, cgx_idx, lmac);

nit: two spaces after assignment operator.

on the point of no new inline: do also check the status in patchwork.
that also flags such issues.