linux-kernel - Re: [PATCH 07/22] perf daemon: Add daemon command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210127220119.GA284633@krava>
Date:   Wed, 27 Jan 2021 23:01:19 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexei Budankov <abudankov@...wei.com>
Subject: Re: [PATCH 07/22] perf daemon: Add daemon command

On Wed, Jan 27, 2021 at 04:09:18PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Sun, Jan 3, 2021 at 7:05 AM Jiri Olsa <jolsa@...nel.org> wrote:
> > +int cmd_daemon(int argc, const char **argv)
> > +{
> > +       struct option daemon_options[] = {
> > +               OPT_INCR('v', "verbose", &verbose, "be more verbose"),
> > +               OPT_STRING(0, "config", &__daemon.config,
> > +                       "config file", "config file path"),
> > +               OPT_STRING_OPTARG('x', "field-separator", &__daemon.csv_sep,
> > +                       "field separator", "print counts with custom separator", ":"),
> 
> Oh, I didn't expect it's optional and default to ":" instead of ",".

np, I can change the default to ','

jirka

> 
> Thanks,
> Namhyung
> 
> 
> > +               OPT_END()
> > +       };
>