linux-kernel - Re: [PATCH v2 0/8] cpupower: Updates and cleanup to support AMD Family 0x19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jan 2021 09:45:45 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Nathan Fontenot <nathan.fontenot@....com>, rrichter@....com,
        shuah@...nel.org, linux-kernel@...r.kernel.org, trenn@...e.com,
        linux-pm@...r.kernel.org
Cc:     boris.ostrovsky@...cle.com, joao.m.martins@...cle.com,
        konrad.wilk@...cle.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 0/8] cpupower: Updates and cleanup to support AMD
 Family 0x19

On 1/25/21 10:34 AM, Nathan Fontenot wrote:
> Updates to the cpupower command to add support for AMD family 0x19
> and cleanup the code to remove many of the family checks to hopefully
> make any future family updates easier.
> 
> The first couple of patches are simple updates to rename the structs
> in the msr_pstate union to better reflect current support and correcting
> the name of the CPUPOWER_CAP_AMD_CPB cpuid cap flag.
> 
> Patches 3, 5, and 8 update the family checks to either replace
> them with a new cpuid cap flag based off of cpuid checks or check for
> family >= 0x17 where removing the direct family check isn't possible.
> 
> The reamianing patches are cleanups to remove unneeded extra enabled bit
> checking, remove passing no longer used variables, and remove unused
> variables in decode_pstates().
> ---
> 
> Updates for v2:
> - Patch 1/8: Add links to AMD PPR and BKDG to commit message.
> - Patch 3/8: Update and add back removed comment.
> 
> ---
> 
> Nathan Fontenot (7):
>        cpupower: Update msr_pstate union struct naming
>        cpupower: Add CPUPOWER_CAP_AMD_HW_PSTATE cpuid caps flag
>        cpupower: Remove unused pscur variable.
>        cpupower: Update family checks when decoding HW pstates
>        cpupower: Condense pstate enabled bit checks in decode_pstates()
>        cpupower: Remove family arg to decode_pstates()
>        cpupower: Add cpuid cap flag for MSR_AMD_HWCR support
> 
> Robert Richter (1):
>        cpupower: Correct macro name for CPB caps flag
> 
> 
>   tools/power/cpupower/utils/cpufreq-info.c    |    3 -
>   tools/power/cpupower/utils/helpers/amd.c     |   65 ++++++++++++--------------
>   tools/power/cpupower/utils/helpers/cpuid.c   |   20 +++++++-
>   tools/power/cpupower/utils/helpers/helpers.h |   14 +++---
>   tools/power/cpupower/utils/helpers/misc.c    |    9 +---
>   5 files changed, 57 insertions(+), 54 deletions(-)
> 
> --
> Nathan Fontenot
> 

Thank you. Applied now for 5.12-rc1

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

thanks,
-- Shuah