linux-kernel - Re: [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Jan 2021 20:29:39 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     mgross@...ux.intel.com, markgross@...nel.org, arnd@...db.de,
        bp@...e.de, damien.lemoal@....com, dragan.cvetic@...inx.com,
        gregkh@...uxfoundation.org, corbet@....net,
        palmerdabbelt@...gle.com, paul.walmsley@...ive.com,
        peng.fan@....com, robh+dt@...nel.org, shawnguo@...nel.org,
        jassisinghbrar@...il.com
Cc:     linux-kernel@...r.kernel.org,
        Ramya P Karanth <ramya.p.karanth@...el.com>
Subject: Re: [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver

On 1/25/21 9:40 PM, mgross@...ux.intel.com wrote:
> diff --git a/drivers/misc/xlink-smbus/Kconfig b/drivers/misc/xlink-smbus/Kconfig
> new file mode 100644
> index 000000000000..e6cdf8b9a096
> --- /dev/null
> +++ b/drivers/misc/xlink-smbus/Kconfig
> @@ -0,0 +1,26 @@
> +# Copyright (C) 2020 Intel Corporation
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config XLINK_SMBUS
> +	tristate "Enable smbus interface over Xlink PCIe"

s/smbus/SMBUS/
as in the other config below.

> +	depends on XLINK_CORE
> +	depends on HDDL_DEVICE_CLIENT || HDDL_DEVICE_SERVER
> +	help
> +	 Enable xlink-pcie as i2c adapter both slave and master. The server

s/i2c/I2C/

> +	 (Remote Host) will use this interface to get sensor data from the soc

s/soc/SOC/  or maybe SoC

> +	 (vision accelerator - Local Host) which is connected over PCIe.
> +	 This driver is loaded on both Remote Host and Local Host.
> +	 Select M to compile the driver as a module, name is xlink-smbus.
> +	 If unsure, select N.

and all of that help text should be indented with one tab + 2 spaces.

> +
> +
> +config XLINK_SMBUS_PROXY
> +	tristate "Enable SMBUS adapter as proxy for I2C controller"
> +	depends on XLINK_CORE
> +	depends on XLINK_SMBUS
> +	help
> +	 Enable this config when SMBUS adapter is acting as proxy for
> +	 another I2C controller.
> +	 Select M or Y if building for Intel Vision Processing Unit (VPU)
> +	 Local Host core.
> +	 Select N, if building for a Remote Host kernel.

All of that help text should be indented with one tab + 2 spaces.


-- 
~Randy
netiquette: https://people.kernel.org/tglx/notes-about-netiquette