linux-kernel - RE: [PATCH v2 29/34] Intel tsens i2c slave driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Jan 2021 04:44:19 +0000
From:   "C, Udhayakumar" <udhayakumar.c@...el.com>
To:     "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        Randy Dunlap <rdunlap@...radead.org>
CC:     "markgross@...nel.org" <markgross@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>, "bp@...e.de" <bp@...e.de>,
        "damien.lemoal@....com" <damien.lemoal@....com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "corbet@....net" <corbet@....net>,
        "leonard.crestez@....com" <leonard.crestez@....com>,
        "palmerdabbelt@...gle.com" <palmerdabbelt@...gle.com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "peng.fan@....com" <peng.fan@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "C@...ux.intel.com" <C@...ux.intel.com>
Subject: RE: [PATCH v2 29/34] Intel tsens i2c slave driver.

> On Mon, Jan 11, 2021 at 11:15:06PM -0800, Randy Dunlap wrote:
> > On 1/8/21 1:25 PM, mgross@...ux.intel.com wrote:
> > > diff --git a/drivers/misc/intel_tsens/Kconfig
> > > b/drivers/misc/intel_tsens/Kconfig
> > > index 8b263fdd80c3..c2138339bd89 100644
> > > --- a/drivers/misc/intel_tsens/Kconfig
> > > +++ b/drivers/misc/intel_tsens/Kconfig
> > > @@ -14,6 +14,20 @@ config INTEL_TSENS_LOCAL_HOST
> > >  	  Say Y if using a processor that includes the Intel VPU such as
> > >  	  Keem Bay.  If unsure, say N.
> > >
> > > +config INTEL_TSENS_I2C_SLAVE
> > > +	bool "I2C slave driver for intel tsens"
> >
> > Why bool instead of tristate?
> Becuase the I2C driver depends on a file scoped global i2c_plat_data
> instanciated in the INTELL_TSENS_LOCAL_HOST DRIVER
> (intel_tsens_thermal.[ch])
> 
> Udhaya, would you care to comment further?
> 
> --mark
> 
As Mark mentioned above, i2c_plat_data from intel_tsens_thermal.[ch] will be used by tsens_i2c client driver.
> 
> >
> > > +	depends on INTEL_TSENS_LOCAL_HOST
> > > +	select I2C
> > > +	select I2C_SLAVE
> > > +	help
> > > +	  This option enables tsens i2c slave driver.
> >
> > 	                            I2C
> >
Will update in v2 version of patch. Thanks for feedback.
> > > +
> > > +	  This driver is used for reporting thermal data via I2C
> > > +	  SMBUS to remote host.
> > > +	  Enable this option if you want to have support for thermal
> > > +	  management controller
> >
> > 	             controller.
> >
Will update in v2 version of patch. Thanks for feedback.
> > > +	  Say Y if using a processor that includes the Intel VPU such as
> > > +	  Keem Bay.  If unsure, say N.
> >
> >
> > --
> > ~Randy
> >