linux-kernel - Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61a387ca-ef02-2ba0-e48e-f25f7e62e6cf@redhat.com>
Date:   Wed, 27 Jan 2021 11:35:49 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Maxim Levitsky <mlevitsk@...hat.com>
Cc:     kvm@...r.kernel.org, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Wanpeng Li <wanpengli@...cent.com>,
        linux-kernel@...r.kernel.org, Jim Mattson <jmattson@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Joerg Roedel <joro@...tes.org>
Subject: Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM:
 nVMX: trace nested vm entry]

On 25/01/21 22:01, Sean Christopherson wrote:
> I 100% think that VMX and SVM should share the bulk of the
> code.  Improvements to VMX almost always apply in some way to SVM, and vice
> versa.

I agree.

> IMO, after debugging a few times, associating
> error_code with the event being injected is second nature.  Prepending
> intr_info_ would just add extra characters and slow down mental processing.
> 
>> of course both it and intr_info are VMX specific).
> 
> Not really, SVM has the exact same fields with slightly different names.
> 

I slightly prefer the SVM names, using eventinj and eventinjerr in the 
trace points wouldn't be bad.

Having too many tracepoints are a problem.  Having a lot of info in a 
single tracepoint is not a problem, though.

Paolo