linux-kernel - Re: [PATCH -next] usb: core: Remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBBTzkPiyMZov9J0@kroah.com>
Date:   Tue, 26 Jan 2021 18:39:26 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     andreyknvl@...gle.com, dvyukov@...gle.com, allen.lkml@...il.com,
        stern@...land.harvard.edu, sashal@...nel.org,
        gustavoars@...nel.org, a.darwish@...utronix.de,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] usb: core: Remove unused including
 <linux/version.h>

On Mon, Jan 25, 2021 at 08:44:48PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
> 
> drivers/usb/core/hcd.c:14:1: unused including <linux/version.h>
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/usb/core/hcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 3f03813..53bc93d 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
>  
>  #include <linux/bcd.h>
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/slab.h>

You didn't test this patch, why???

{sigh}

greg k-h