linux-kernel - Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBLwXgUJR4L6IiSl@epycbox.lan>
Date:   Thu, 28 Jan 2021 09:11:58 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     lorenzo.pieralisi@....com, Moritz Fischer <mdf@...nel.org>,
        Will Deacon <will@...nel.org>, guohanjun@...wei.com,
        sudeep.holla@....com, linux-acpi@...r.kernel.org,
        moritzf@...gle.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, rjw@...ysocki.net
Subject: Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from
 firmware

Hi Catalin,

On Wed, Jan 27, 2021 at 01:09:36PM +0000, Catalin Marinas wrote:
> On Thu, 21 Jan 2021 17:24:19 -0800, Moritz Fischer wrote:
> > Address issue observed on real world system with suboptimal IORT table
> > where DMA masks of PCI devices would get set to 0 as result.
> > 
> > iort_dma_setup() would query the root complex'/named component IORT
> > entry for a DMA mask, and use that over the one the device has been
> > configured with earlier.
> > 
> > [...]
> 
> Applied to arm64 (for-next/fixes), thanks!
> 
> [1/1] ACPI/IORT: Do not blindly trust DMA masks from firmware
>       https://git.kernel.org/arm64/c/a1df829ead58
> 
> -- 
> Catalin
> 

Should we consider this for stable, too? If so I can send an email to
stable@ once it's in Linus' tree, since I'm the one forgetting to CC
stable in the first place :)

It would be nice if at least 5.10 would get this.

Cheers,
Moritz