linux-kernel - Re: [PATCH v3 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161185401247.76967.894387173080815413@swboyd.mtv.corp.google.com>
Date:   Thu, 28 Jan 2021 09:13:32 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH v3 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

Quoting Enric Balletbo Serra (2021-01-28 01:58:48)
> Missatge de Stephen Boyd <swboyd@...omium.org> del dia dj., 28 de gen.
> 2021 a les 9:48:
> > diff --git a/drivers/iio/proximity/cros_ec_mkbp_proximity.c b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > new file mode 100644
> > index 000000000000..c8f33cf11b42
> > --- /dev/null
> > +++ b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > @@ -0,0 +1,245 @@
> > +       data->notifier.notifier_call = cros_ec_mkbp_proximity_notify;
> > +       ret = blocking_notifier_chain_register(&ec->event_notifier,
> > +                                              &data->notifier);
> > +       if (ret)
> > +               dev_err(dev, "cannot register notifier: %d\n", ret);
> > +
> > +       return ret;
> 
> blocking_notifier_chain_register always return 0, so the error path
> will never happen, you can simplify this a bit with directly:
> 
> return blocking_notifier_chain_register(&ec->event_notifier, &data->notifier);
> 
> Other than this minor nit
> 
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> 

Cool thanks! I've rolled it into a v4 but I'll wait a day or so for any
more comments before sending again.