linux-kernel - Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jan 2021 18:23:29 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Alexandre GRIVEAUX <agriveaux@...tnet.info>
Cc:     robh+dt@...nel.org, wens@...e.org, jernej.skrabec@...l.net,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2

Hi,

On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote:
> Add Inet 86V Rev 2 support, based upon Inet 86VS.
> 
> The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
> which make them both incompatible.
> 
> Missing things:
> - Accelerometer (MXC6225X)
> - Touchpanel (Sitronix SL1536)
> - Nand (29F32G08CBACA)
> - Camera (HCWY0308)
> 
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@...tnet.info>
> ---
>  arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++

You have to add it to the Makefile

>  1 file changed, 17 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> 
> diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> new file mode 100644
> index 000000000000..581083e932d8
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright 2021 Alexandre Griveaux <agriveaux@...tnet.info>
> + *
> + * Minimal dts file for the iNet 86V
> + */
> +
> +/dts-v1/;
> +
> +#include "sun5i-a13.dtsi"
> +#include "sun5i-reference-design-tablet.dtsi"
> +
> +/ {
> +	model = "iNET 86V Rev 02";
> +	compatible = "inet,86v-rev2", "allwinner,sun5i-a13";

inet should be documented in the vendor prefixes, and that compatible
should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml

Having the first rev compatible would be good too

> +
> +};

But I'm wondering. If there's nothing here to add, why would we need
that DT in the first place?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)