[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210128175549.j5mc72mjjnh6aalk@begin>
Date: Thu, 28 Jan 2021 18:55:49 +0100
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, speakup@...ux-speakup.org
Subject: Re: [PATCH] speakup: Make dectlk flush timeout configurable
Greg KH, le jeu. 28 janv. 2021 08:54:16 +0100, a ecrit:
> On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote:
> > static struct kobj_attribute full_time_attribute =
> > __ATTR(full_time, 0644, spk_var_show, spk_var_store);
> > +static struct kobj_attribute flush_time_attribute =
> > + __ATTR(flush_time, 0644, spk_var_show, spk_var_store);
>
> __ATTR_RW()?
Unfortunately no because __ATTR_RW only takes the name, and uses that
for the function to be called. In our case the functions are shared.
> Also, no Documentation/ABI/ update for the new one user-visable
> attribute? Please fix up.
Right, I'll fix it.
Samuel
Powered by blists - more mailing lists