lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jan 2021 19:35:06 +0100 From: Alexander Sverdlin <alexander.sverdlin@...il.com> To: Nikita Shubin <nikita.shubin@...uefel.me> Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 3/7] gpio: gpio-ep93xx: Fix wrong irq numbers in port F Hi! On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote: > Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE. > > So we need to specify girq->first otherwise: > > "If device tree is used, then first_irq will be 0 and > irqs get mapped dynamically on the fly" > > And that's not the thing we want. > > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me> Acked-by: Alexander Sverdlin <alexander.sverdlin@...il.com> > --- > drivers/gpio/gpio-ep93xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c > index b990d37da143..dc88115e34da 100644 > --- a/drivers/gpio/gpio-ep93xx.c > +++ b/drivers/gpio/gpio-ep93xx.c > @@ -430,6 +430,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip > *gc, > girq->default_type = IRQ_TYPE_NONE; > girq->handler = handle_level_irq; > gc->to_irq = ep93xx_gpio_f_to_irq; > + girq->first = EP93XX_GPIO_F_IRQ_BASE; > } > > return devm_gpiochip_add_data(dev, gc, epg); -- Alexander Sverdlin.
Powered by blists - more mailing lists