linux-kernel - Re: [PATCH] memory: tegra: Remove calls to dev_pm_opp_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210128041855.4sovmu3bnbq7efaa@vireshk-i7>
Date:   Thu, 28 Jan 2021 09:48:55 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] memory: tegra: Remove calls to dev_pm_opp_set_clkname()

On 27-01-21, 22:27, Dmitry Osipenko wrote:
> 27.01.2021 13:16, Viresh Kumar пишет:
> > There is no point calling dev_pm_opp_set_clkname() with the "name"
> > parameter set to NULL, this is already done by the OPP core at setup
> > time and should work as it is.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > 
> > ---
> > V2: Update tegra124 as well.
> > 
> > Krzysztof, please take this through your tree, it doesn't have any
> > dependency in the OPP tree.
> > ---
> >  drivers/memory/tegra/tegra124-emc.c | 13 ++-----------
> >  drivers/memory/tegra/tegra20-emc.c  | 13 ++-----------
> >  drivers/memory/tegra/tegra30-emc.c  | 13 ++-----------
> >  3 files changed, 6 insertions(+), 33 deletions(-)
> 
> Ideally drivers should be able to ensure that OPP table received the
> clk, IMO.

I don't really agree with that, this stuff is internal to the OPP
core. And it should all work unless there is a bug, whose effects we
will see anyway.

> But this is also almost fine with me since realistically
> clk_get() shouldn't fail if it already succeeded a moment ago.
> 
> Reviewed-by: Dmitry Osipenko <digetx@...il.com>
> Tested-by: Dmitry Osipenko <digetx@...il.com>

Thanks.

Krzysztof, please apply the patch to your tree. Thanks.

> Could we please fix the _allocate_opp_table() to not ignore clk_get()
> errors like -ENOMEM and etc?

Maybe we should fail if the error is anything other than -ENODEV ?

-- 
viresh