linux-kernel - Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Jan 2021 15:39:07 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Christoph Jaeger <cj@...ux.com>,
        Andy Whitcroft <apw@...onical.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in
 Kconfig definitions"

On Wed, Jan 27, 2021 at 12:02 PM Joe Perches <joe@...ches.com> wrote:
>
> On Wed, 2021-01-27 at 04:15 +0900, Masahiro Yamada wrote:
> > This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
> >
> > You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
> > 'boolean' keyword").
> >
> > This check is no longer needed.
>

Applied to linux-kbuild.


> Thanks.
>
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Acked-by: Joe Perches <joe@...ches.com>
>
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3390,13 +3390,6 @@ sub process {
> >                       }
> >               }
> >
> > -# discourage the use of boolean for type definition attributes of Kconfig options
> > -             if ($realfile =~ /Kconfig/ &&
> > -                 $line =~ /^\+\s*\bboolean\b/) {
> > -                     WARN("CONFIG_TYPE_BOOLEAN",
> > -                          "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> > -             }
> > -
> >               if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
> >                   ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
> >                       my $flag = $1;
>
>


-- 
Best Regards
Masahiro Yamada