linux-kernel - Re: [PATCH v2 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210127163812.76fa0411@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 27 Jan 2021 16:38:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Cc:     netdev@...r.kernel.org, jiri@...dia.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: core: devlink: add 'dropped' stats
 field for DROP trap action

On Mon, 25 Jan 2021 14:31:21 +0200 Oleksandr Mazur wrote:
> Whenever query statistics is issued for trap with DROP action,
> devlink subsystem would also fill-in statistics 'dropped' field.
> In case if device driver did't register callback for hard drop
> statistics querying, 'dropped' field will be omitted and not filled.
> Add trap_drop_counter_get callback implementation to the netdevsim.
> Add new test cases for netdevsim, to test both the callback
> functionality, as well as drop statistics alteration check.
> 
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@...ision.eu>

Please stick to RFC since there is no upstream user for this (if you
need to repost).