linux-kernel - Re: [abaci-bugfix@...ux.alibaba.com: [PATCH] s390: Simplify the calculation of variables]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7cb0b636-35b2-21d9-af92-37431f1d0e2e@linux.ibm.com>
Date:   Thu, 28 Jan 2021 08:05:05 +0100
From:   Vineeth Vijayan <vneethv@...ux.ibm.com>
To:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
Cc:     gor@...ux.ibm.com, borntraeger@...ibm.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>
Subject: Re: [abaci-bugfix@...ux.alibaba.com: [PATCH] s390: Simplify the
 calculation of variables]

> Date: Tue, 26 Jan 2021 17:09:12 +0800
> From: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
> To: hca@...ux.ibm.com
> Cc: , Jiapeng Zhong
> 	<abaci-bugfix@...ux.alibaba.com>
> Subject: [PATCH] s390: Simplify the calculation of variables
> Message-Id: <1611652152-58139-1-git-send-email-abaci-bugfix@...ux.alibaba.com>
> X-Mailer: git-send-email 1.8.3.1
>
> Fix the following coccicheck warnings:
>
> ./arch/s390/include/asm/scsw.h:528:48-50: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
> ---
>   arch/s390/include/asm/scsw.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/include/asm/scsw.h b/arch/s390/include/asm/scsw.h
> index c00f7b0..a7c3ccf 100644
> --- a/arch/s390/include/asm/scsw.h
> +++ b/arch/s390/include/asm/scsw.h
> @@ -525,8 +525,7 @@ static inline int scsw_cmd_is_valid_pno(union scsw *scsw)
>   	return (scsw->cmd.fctl != 0) &&
>   	       (scsw->cmd.stctl & SCSW_STCTL_STATUS_PEND) &&
>   	       (!(scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) ||
> -		 ((scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) &&
> -		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED)));
> +		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED));
>   }
>   
>   /**

Thank you.

Reviewed-by: Vineeth Vijayan <vneethv@...ux.ibm.com>

this will go via next s390-tree upstream-release.

Regards
Vineeth Vijayan.