linux-kernel - Re: [PATCH 2/4] perf vendor events arm64: Add common and uarch event JSON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a668afcc-b06b-04d3-aba2-507a8d1d8f6e@huawei.com>
Date:   Thu, 28 Jan 2021 08:41:57 +0000
From:   John Garry <john.garry@...wei.com>
To:     "nakamura.shun@...itsu.com" <nakamura.shun@...itsu.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxarm@...neuler.org" <linuxarm@...neuler.org>,
        "james.clark@....com" <james.clark@....com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "irogers@...gle.com" <irogers@...gle.com>,
        "kjain@...ux.ibm.com" <kjain@...ux.ibm.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/4] perf vendor events arm64: Add common and uarch event
 JSON

On 28/01/2021 05:30, nakamura.shun@...itsu.com wrote:
> Hi ,john
> 
> I would like to make a comment because there is excess or deficiency in comma.
> There are no differences in pmu-events.c.
> 
>> +    {
>> +        "PublicDescription": "Attributable Bus access",
>> +        "EventCode": "0x19",
>> +        "EventName": "BUS_ACCESS",
>> +        "BriefDescription": "Attributable Bus access",
>> +    },
> Comma is not required at the end of BriefDescription.
> 
>> +    {
>> +        "PublicDescription": "Bus cycle"
>> +        "EventCode": "0x1D",
>> +        "EventName": "BUS_CYCLES",
>> +        "BriefDescription": "Bus cycle"
>> +    },
> Missing comma at end of PublicDescription.
> 
>> +    {
>> +        "PublicDescription": "Attributable Last level cache memory read"
>> +        "EventCode": "0x36",
>> +        "EventName": "LL_CACHE_RD",
>> +        "BriefDescription": "Attributable Last level cache memory read"
>> +    },
>> +    {
>> +        "PublicDescription": "Last level cache miss, read"
>> +        "EventCode": "0x37",
>> +        "EventName": "LL_CACHE_MISS_RD",
>> +        "BriefDescription": "Last level cache miss, read"
>> +    },
> Missing comma at end of PublicDescription.
> 
>> +    },
>> +]
> Commas are not required.
> 
> Best Regards
> Shunsuke

Fine, I can fix those up and re-post today.

Thanks,
john