linux-kernel - Re: [PATCH] KVM: x86: fix CPUID entries returned by KVM_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <304bd6db-4c67-a4bd-3b79-74c0474edefa@redhat.com>
Date:   Thu, 28 Jan 2021 09:43:05 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Michael Roth <michael.roth@....com>, kvm@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H . Peter Anvin" <hpa@...or.com>,
        linux-kernel@...r.kernel.org,
        Michael Roth <michael.roth@....com.com>
Subject: Re: [PATCH] KVM: x86: fix CPUID entries returned by KVM_GET_CPUID2
 ioctl

On 28/01/21 09:36, Vitaly Kuznetsov wrote:
> This is embarrassing but I have a (possible) excuse: copy_to_user's
> argument is 'void *' so no warning was produced. Surprisingly, no test
> caught the breakage. Thanks for debugging and fixing!

So who writes the test:

- the author of the buggy patch

- the maintainer who failed to spot it

- the poor sod who fixed the issue

?

(Just kidding, it will of course be either me or a fourth person :)).

Paolo