linux-kernel - Re: [PATCH v4] power: suspend: Move dpm_watchdog to suspend.c and enhance it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <00000000000004f27505b9f26bca@google.com>
Date:   Thu, 28 Jan 2021 09:21:52 +0000
From:   <josephjang@...gle.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>, rafael@...nel.org,
        gregkh@...uxfoundation.org, rjw@...ysocki.net, pavel@....cz,
        len.brown@...el.com, pmladek@...e.com,
        sergey.senozhatsky@...il.com, rostedt@...dmis.org,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        jonglin@...gle.com, woodylin@...gle.com, markcheng@...gle.com,
        josephjang@...gle.com
Subject: Re: [PATCH v4] power: suspend: Move dpm_watchdog to suspend.c and
 enhance it

> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 867157311dc8..ecd988b4a838 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7788,6 +7788,8 @@ F:        include/linux/freezer.h
> >  F:     include/linux/pm.h
> >  F:     include/linux/suspend.h
> >  F:     kernel/power/
> > +F:     kernel/power/suspend_watchdog.c
> > +F:     kernel/power/suspend_watchdog.h
> >

> The kernel/power/ file entry already covers all files in that
> directory, including suspend_watchdog.[ch].

> So, why do you think you need to add these two further entries explicitly  
> here?

> >  HID CORE LAYER
> >  M:     Jiri Kosina <jikos@...nel.org>
> > @@ -16630,6 +16632,8 @@ F:      include/linux/freezer.h
> >  F:     include/linux/pm.h
> >  F:     include/linux/suspend.h
> >  F:     kernel/power/
> > +F:     kernel/power/suspend_watchdog.c
> > +F:     kernel/power/suspend_watchdog.h
> >

> Same here.

> I think you can simply drop the changes in MAINTAINERS in this patch.

Sure~
I will drop the changes in MAINTAINERS and send PATCH#6 again.

Thank you,
Joseph.