linux-kernel - Re: [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jan 2021 15:28:00 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Russell King <rmk+kernel@....linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Will Deacon <will.deacon@....com>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>,
        Wei Xu <xuwei5@...ilicon.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC

On Sat, Jan 16, 2021 at 4:32 AM Zhen Lei <thunder.leizhen@...wei.com> wrote:
>
> Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>  arch/arm/mach-hisi/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
> index 2e980f834a6aa1b..c724acc5c642b97 100644
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -55,6 +55,14 @@ config ARCH_HIX5HD2
>         help
>           Support for Hisilicon HIX5HD2 SoC family
>
> +config ARCH_KUNPENG50X
> +       bool "Hisilicon Kunpeng50x family"
> +       depends on ARCH_MULTI_V7
> +       select ARCH_FLATMEM_ENABLE
> +       select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM

I think the two 'select' statements are both wrong, though for
different reasons:

- ARCH_FLATMEM_ENABLE is already selected by ARCH_MULTIPLATFORM,
  and is something that should not be platform specific

- ARCH_HAS_HOLES_MEMORYMODEL was removed in v5.11,
  and should also not be selected by a platform.

Otherwise, this seems fine.

         Arnd