linux-kernel - Re: [RFC PATCH 0/4] Asynchronous passthrough ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d847f4a-65a5-bc62-1d36-52e222e3d142@kernel.dk>
Date:   Thu, 28 Jan 2021 07:50:09 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Kanchan Joshi <joshiiitr@...il.com>,
        Pavel Begunkov <asml.silence@...il.com>
Cc:     Kanchan Joshi <joshi.k@...sung.com>,
        Keith Busch <kbusch@...nel.org>,
        Christoph Hellwig <hch@....de>, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org, io-uring@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Javier Gonzalez <javier.gonz@...sung.com>,
        Nitesh Shetty <nj.shetty@...sung.com>,
        Selvakumar S <selvakuma.s1@...sung.com>
Subject: Re: [RFC PATCH 0/4] Asynchronous passthrough ioctl

On 1/28/21 5:04 AM, Kanchan Joshi wrote:
> And for some ioctls, driver may still need to use task-work to update
> the user-space pointers (embedded in uring/ioctl cmd) during
> completion.

For this use case, we should ensure that just io_uring handles this
part. It's already got everything setup for it, and I'd rather avoid
having drivers touch any of those parts. Could be done by having an
io_uring helper ala:

io_uring_cmd_complete_in_task(cmd, handler);

which takes care of the nitty gritty details.

-- 
Jens Axboe