linux-kernel - Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANqTbdYLmbGe9GQB6QE5pdrsJYTXZo--PUEhE87-0pZCQzuYag@mail.gmail.com>
Date:   Fri, 29 Jan 2021 02:07:13 +1100
From:   Victor Ding <victording@...gle.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mmc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org,
        Ben Chuang <ben.chuang@...esyslogic.com.tw>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        "Saheed O. Bolarinwa" <refactormyself@...il.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        Yicong Yang <yangyicong@...ilicon.com>
Subject: Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

On Fri, Jan 29, 2021 at 12:44 AM Krzysztof Wilczyński <kw@...ux.com> wrote:
>
> Hi Victor,
>
> Thank you for working on this!
>
> [...]
> >       i = pci_save_pcie_state(dev);
> >       if (i != 0)
> > -             return i;
> > +             goto Exit;
> >
> >       i = pci_save_pcix_state(dev);
> >       if (i != 0)
> > -             return i;
> > +             goto Exit;
> [...]
> > +Exit:
> > +     pcie_restore_aspm_control(dev);
> > +     return i;
> >  }
> [...]
>
> A silly thing, but the goto labels are customary lower-case.
>
> Nonetheless, this is probably something that can be corrected when
> applying, so that you don't need to unnecessarily send a new version
> (unless you will eventually following other reviews, then don't forget
> about it).
>
> Krzysztof

Thank you for reviewing. I am about to send out a V2 for a bug fix,
it will include this style change too.

Victor