linux-kernel - Re: [PATCH v12] staging: fbtft: add tearing signal detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210128152352.GH2696@kadam>
Date:   Thu, 28 Jan 2021 18:23:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Carlis <zhangxuezhi3@...il.com>,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
        "open list:FRAMEBUFFER LAYER" <linux-fbdev@...r.kernel.org>,
        Deepak R Varma <mh12gx2825@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        oliver.graute@...oconnector.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Stefano Brivio <sbrivio@...hat.com>,
        Colin King <colin.king@...onical.com>, zhangxuezhi1@...ong.com
Subject: Re: [PATCH v12] staging: fbtft: add tearing signal detect

On Thu, Jan 28, 2021 at 04:33:02PM +0200, Andy Shevchenko wrote:
> > +               init_completion(&spi_panel_te);
> > +               rc = devm_request_irq(dev,
> 
> > +                                     gpiod_to_irq(par->gpio.te),
> 
> ...and here simply use irq.
> 
> > +                                    spi_panel_te_handler, IRQF_TRIGGER_RISING,
> > +                                    "TE_GPIO", par);
> 
> > +               if (IS_ERR(rc))
> 
> This is wrong. rc is integer no IS_ERR() is required. Ditto for
> PTR_ERR(). Have you even looked for these macros implementations?
> 

Yeah...  It leads to a compile warning:

	warning: passing argument 1 of ‘IS_ERR’ makes pointer from integer without a cast [-Wint-conversion]

regards,
dan carpenter