linux-kernel - Re: [PATCH v2 0/3] handle large user and group ID for isofs and udf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMmgxWGY9SAsKRj4u7qZr=-tjO2+gcbJ9TeME1hwk_ajJFTW0w@mail.gmail.com>
Date:   Fri, 29 Jan 2021 13:33:01 +0800
From:   bingjing chang <bxxxjxxg@...il.com>
To:     Jan Kara <jack@...e.cz>, Matthew Wilcox <willy@...radead.org>
Cc:     viro@...iv.linux.org.uk, jack@...e.com, axboe@...nel.dk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        cccheng@...ology.com, robbieko@...ology.com, rdunlap@...radead.org,
        David Howells <dhowells@...hat.com>,
        bingjingc <bingjingc@...ology.com>
Subject: Re: [PATCH v2 0/3] handle large user and group ID for isofs and udf

Hi Jan & Matthew,

Thank you for your kind notices and comments. Please see my message
below.

bingjingc <bingjingc@...ology.com> 於 2021年1月29日 週五 下午1:06寫道：
>
> [loop bxxxjxxg@...il.com] in order to reply in plain-text
>
> Matthew Wilcox <willy@...radead.org> 於 2021-01-28 22:20 寫道：
>
> On Thu, Jan 28, 2021 at 11:55:01AM +0100, Jan Kara wrote:
> > On Thu 28-01-21 15:12:27, bingjingc wrote:
> > > From: BingJing Chang <bingjingc@...ology.com>
> > >
> > > The uid/gid (unsigned int) of a domain user may be larger than INT_MAX.
> > > The parse_options of isofs and udf will return 0, and mount will fail
> > > with -EINVAL. These patches try to handle large user and group ID.
> > >
> > > BingJing Chang (3):
> > >   parser: add unsigned int parser
> > >   isofs: handle large user and group ID
> > >   udf: handle large user and group ID
> >
> > Thanks for your patches! Just two notes:
> >
> > 1) I don't think Matthew Wilcox gave you his Reviewed-by tag (at least I
> > didn't see such email). Generally the rule is that the developer has to
> > explicitely write in his email that you can attach his Reviewed-by tag for
> > it to be valid.
>
> Right, I didn't.

Sorry, I don't know how Reviewed-by tag works in emailing code review
procedures. Thank for talking me the rule. I drop Matthew's Reviewed-by
tag in the third patch.

>
> Looking at fuse, they deleted their copy of match_uint
> in favour of switching to the fs_parameter_spec (commit
> c30da2e981a703c6b1d49911511f7ade8dac20be) and I wonder if isofs & udf
> shouldn't receive the same attention.

That's true. New mount API can handle uint_32 by fs_parse.
It may take a little larger coding and review works converting isofs and udf
to use the new mount API. And we also want these fixes can be also applied
back to previous stable kernels. So we'd like to submit this patch to solve the
iso image mounting bugs first.


Thanks,
BingJing