linux-kernel - Re: [PATCH 3/3] parser: add unsigned int parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMmgxWFMBxg47J_Zjdfm5i36m3TMf2VEzoeREGKD6VFJXcbN3A@mail.gmail.com>
Date:   Fri, 29 Jan 2021 14:00:59 +0800
From:   bingjing chang <bxxxjxxg@...il.com>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.com>,
        Jan Kara <jack@...e.cz>, Jens Axboe <axboe@...nel.dk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        cccheng@...ology.com, robbieko@...ology.com,
        bingjingc <bingjingc@...ology.com>
Subject: Re: [PATCH 3/3] parser: add unsigned int parser

Hi Miklos,

Thank you for your mail. Please see my message below.

bingjingc <bingjingc@...ology.com> 於 2021年1月29日 週五 下午1:50寫道：
>
> [loop bxxxjxxg@...il.com] in order to reply in plain-text
> Miklos Szeredi <miklos@...redi.hu> 於 2021-01-28 16:37 寫道：
>
> On Thu, Jan 28, 2021 at 3:21 AM bingjingc <bingjingc@...ology.com> wrote:
> >
> > From: BingJing Chang <bingjingc@...ology.com>
> >
> > Will be used by fs parsing options
> >
> > Reviewed-by: Robbie Ko<robbieko@...ology.com>
> > Reviewed-by: Chung-Chiang Cheng <cccheng@...ology.com>
> > Signed-off-by: BingJing Chang <bingjingc@...ology.com>
> > ---
> >  fs/isofs/inode.c       | 16 ++--------------
> >  fs/udf/super.c         | 16 ++--------------
> >  include/linux/parser.h |  1 +
> >  lib/parser.c           | 22 ++++++++++++++++++++++
> >  4 files changed, 27 insertions(+), 28 deletions(-)
> >
> > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> > index 342ac19..21edc42 100644
> > --- a/fs/isofs/inode.c
> > +++ b/fs/isofs/inode.c
> > @@ -335,18 +335,6 @@ static const match_table_t tokens = {
> >         {Opt_err, NULL}
> >  };
> >
> > -static int isofs_match_uint(substring_t *s, unsigned int *res)
> > -{
> > -       int err = -ENOMEM;
> > -       char *buf = match_strdup(s);
> > -
> > -       if (buf) {
> > -               err = kstrtouint(buf, 10, res);
> > -               kfree(buf);
> > -       }
> > -       return err;
> > -}
>
> I don't see how adding this function and removing it in the same
> series makes any sense.

That's true. Simple and clear is better.
I used to think that the acceptance of patch can be 3/3 or 2/3.
And I was not sure are there needs for making match_uint
as shared lib. So I made the first patch.

I simplify them. Please see the third patch, thanks!

>
> Why not make this the first patch in the series, simplifying everything?
>
> And while at it the referenced fuse implementation can also be
> converted (as a separate patch).
>
> Thanks,
> Miklos

Thanks,
BingJing