linux-kernel - Re: [PATCH] pwm: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2152a64-d4ae-f18d-9af7-b80b12474b00@mleia.com>
Date:   Fri, 29 Jan 2021 18:51:54 +0200
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pwm: fix semicolon.cocci warnings

On 1/28/21 10:57 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@...el.com>
>>
>> drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>>
>>
>>   Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")
> 
> This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.
> 
> The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
> driver")

Right, thank you for the correction, Uwe.

Since the patch has been composed by the robot, it has to be fixed
in the first place.

And regarding this particular change and in general fixes to this type
of issues detected by the robot, I don't think that it earns a Fixes tag.

>> CC: Krzysztof Kozlowski <krzk@...nel.org>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: kernel test robot <lkp@...el.com>

--
Best wishes,
Vladimir