linux-kernel - Re: [PATCH 1/4] drivers: phy: add support for Armada CP110 UTMI PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210129182219.GA74013@demiurge.local>
Date:   Fri, 29 Jan 2021 19:22:19 +0100
From:   Lubomir Rintel <lkundrak@...sk>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     kostap@...vell.com, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        sebastian.hesselbarth@...il.com, gregory.clement@...tlin.com,
        andrew@...n.ch, robh+dt@...nel.org, vkoul@...nel.org,
        kishon@...com, miquel.raynal@...tlin.com, mw@...ihalf.com,
        jaz@...ihalf.com, nadavh@...vell.com, stefanc@...vell.com,
        bpeled@...vell.com
Subject: Re: [PATCH 1/4] drivers: phy: add support for Armada CP110 UTMI PHY

On Fri, Jan 29, 2021 at 10:07:13AM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Jan 29, 2021 at 10:28:49AM +0100, Lubomir Rintel wrote:
> > > +	/*
> > > +	 * Setup PLL. 40MHz clock used to be the default, being 25MHz now.
> > > +	 * See the functional specification for details.
> > 
> > I tried to, couldn't find it. Perhaps you could elaborate more here, or
> > include a link in the header.
> 
> Marvell documents are generally not publically available. This is the
> case here.

In that case the "elaborate more" part applies, otherwise the comment
remains rather meaningless. Perhaps it wouldn't be too difficult to
clarify things with an extra sentence or two without revealing any
secrets.

> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Take care
Lubo