linux-kernel - Re: [5.11 regression] "tty: implement write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8723f53e-9954-e0d2-16ce-933f53c776c3@redhat.com>
Date:   Fri, 29 Jan 2021 19:31:33 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

Hi Linus,

On 1/29/21 7:23 PM, Hans de Goede wrote:
> Hi,
> 
> On 1/29/21 7:09 PM, Linus Torvalds wrote:
>> On Fri, Jan 29, 2021 at 6:54 AM Hans de Goede <hdegoede@...hat.com> wrote:
>>>
>>> While testing 5.11-rc5 I noticed that flicker-free boot was no longer flicker free,
>>> when plymouth loads and tells systemd to start logging detailed messages these start
>>> showing upon the fbcon instead of being redirected to the ptmx which plymouth is
>>> trying to redirect the messages too.
>>
>> I think this should already be fixed in current -git by commit 9f12e37cae44.
>>
>> Can you check?
> 
> So I just did the following
> 
> 1. Started with my local tree (5.11-rc5 + patches I'm working on, nothing tty related)
>    ( https://github.com/jwrdegoede/linux-sunxi/commits/master )
> 2. Dropped the 2 reverts which I was carrying to workaround this locally
> 3. Cherry-picked 9f12e37cae44
> 4. Build + installed a new bzImage
> 
> Unfortunately this does not resolve the problem, after this the problem is back.
> 
> I can build a kernel from a clean torvalds/linux/master but I don't expect
> any different results from that. Let me know if you still want me to do
> a clean build to make sure this is not something in my local tree.

p.s.

You are using Fedora now a days, right ?  In that case you should be
able to reproduce this yourself (depending on how custom your kernel
setup is) if you are using the standard Fedora initrd generated by
dracut and have "rhgb" on your kernel cmdline, then you can check
for this problem by doing:

sudo cat /var/log/boot.log 

For me the end of that file looks like this:

------------ Wed Jan 27 08:28:15 CET 2021 ------------
------------ Wed Jan 27 17:27:53 CET 2021 ------------
------------ Thu Jan 28 11:11:50 CET 2021 ------------
------------ Fri Jan 29 10:32:04 CET 2021 ------------
------------ Fri Jan 29 19:16:40 CET 2021 ------------
------------ Fri Jan 29 19:19:05 CET 2021 ------------

There should be lines like this in between those separators
(each separator is the start of the logs of a new boot):

[  OK  ] Started User Login Management.
[  OK  ] Started GNOME Display Manager.
etc.

Regards,

Hans