linux-kernel - Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8c2e8be-7a5a-83a0-fc86-2bdd1095c33d@novek.ru>
Date:   Fri, 29 Jan 2021 19:53:42 +0000
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     David Howells <dhowells@...hat.com>
Cc:     syzbot+df400f2f24a1677cd7e0@...kaller.appspotmail.com,
        netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on
 udp tunnel

On 29.01.2021 17:41, David Howells wrote:
> Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
> 
>> You missed the call to dst_release(sk->sk_rx_dst) in
>> rxrpc_sock_destructor. Without it we are still leaking the dst.
> 
> Hmmm...  I no longer get the messages appearing with this patch.  I'll have
> another look.

Sorry, my bad. rxrpc_sock_destructor destroys AF_RXRPC sockets, which are 
totally different from the UDP kernel socket used as a transport and which are 
destroyed as usual UDP sockets.

Ack-by: Vadim Fedorenko <vfedorenko@...ek.ru>