linux-kernel - Re: [5.11 regression] "tty: implement write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98a4e417-bd2e-6333-47f2-36bf96d53053@redhat.com>
Date:   Fri, 29 Jan 2021 22:09:55 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>,
        Jiufei Xue <jiufei.xue@...ux.alibaba.com>,
        Miklos Szeredi <mszeredi@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

Hi,

On 1/29/21 9:28 PM, Linus Torvalds wrote:
> On Fri, Jan 29, 2021 at 12:02 PM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> It's fairly easy to work around in this in the tty layer by just
>> avoiding that function entirely, so I'll cook up a patch to do that.
>> But I'm adding the appropriate people to the participants here because
>> this really is very subtle if you ever hit it.
> 
> Here's the patch to make the tty layer just do the redirection
> entirely internally, avoiding that mis-designed vfs_iocb_iter_write()
> function.
> 
> Hans, does this fix things for you? I'm pretty confident it will, but
> always best to double-check..

I can confirm that the attached patch fixes things for me, thanks.

Regards,

Hans