linux-kernel - Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUXMxM4CuNa0P+JFJO7LSj6QvJneArYXpqLRJrzqJMYj6g@mail.gmail.com>
Date:   Fri, 29 Jan 2021 23:42:13 +0100
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor <natechancellor@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Clang-Built-Linux ML <clang-built-linux@...glegroups.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Jakub Jelinek <jakub@...hat.com>,
        Fangrui Song <maskray@...gle.com>,
        Caroline Tice <cmtice@...gle.com>,
        Nick Clifton <nickc@...hat.com>, Yonghong Song <yhs@...com>,
        Jiri Olsa <jolsa@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Arvind Sankar <nivedita@...m.mit.edu>
Subject: Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

On Fri, Jan 29, 2021 at 11:31 PM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers
> > <ndesaulniers@...gle.com> wrote:
> > >
> > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> > > >
> > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers
> > > > <ndesaulniers@...gle.com> wrote:
> > > > >
> > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> > > > > >
> > > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> > > > > > >
> > > > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers
> > > > > > > <ndesaulniers@...gle.com> wrote:
> > > > > > > >
> > > > > > > > Can you tell me please what is the precise command line invocation of
> > > > > > > > make and which source file you observed this on so that I can
> > > > > > > > reproduce?
> > > > >
> > > > > If you don't send me your invocation of `make`, I cannot help you.
> > > > >
> > > >
> > > > /usr/bin/perf_5.10 stat make V=1 -j4 LLVM=1 LLVM_IAS=1
> > > > PAHOLE=/opt/pahole/bin/pahole LOCALVERSION=-10-amd64-clang12
> > > > -lto-pgo KBUILD_VERBOSE=1 KBUILD_BUILD_HOST=iniza
> > > > KBUILD_BUILD_USER=sedat.dilek@...il.com
> > > > KBUILD_BUILD_TIMESTAMP=2021-01-29 bindeb-pkg
> > > > KDEB_PKGVERSION=5.11.0~rc5-10~bullseye+dileks1
> > >
> > > $ make LLVM=1 LLVM_IAS=1 -j72 defconfig
> > > $ make LLVM=1 LLVM_IAS=1 -j72 menuconfig
> > > <enable CONFIG_DEBUG_INFO and CONFIG_DEBUG_INFO_DWARF5>
> > > $ make LLVM=1 LLVM_IAS=1 -j72 V=1 &> log.txt
> > > $ grep '\-g -gdwarf-5 -g -gdwarf-5' log.txt | wc -l
> > > 0
> > > $ grep '\-g -gdwarf-5' log.txt | wc -l
> > > 2517
> > >
> > > Do have the patch applied twice, perhaps?
> > >
> >
> > Switched to my v6 local Git branch and invoked above make line I gave you.
> > I still see that double.
> > Looks like I need some "undrunken" switch.
>
> Can you follow my steps precisely to see whether it's your .config?
> Perhaps there is a config that duplicates DEBUG_CFLAGS that is not set
> in the defconfig?  If so, it's still harmless to specify the same
> commands twice, and likely isn't introduced by this patch set if so;
> so I'm not sure how much more effort is worth pursuing.
>

If I follow your steps of make I do not see it "double" (in my local
v6 Git branch).

Looks like this is coming from my build-script.

I checked if I have some double dwarf(-5) patches double - Nope.

- Sedat -