linux-kernel - Re: [PATCH] lib: crc8: Pointer to data block should be const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eafaab98-9300-a155-c0ac-6fe2aa1cf3d6@infradead.org>
Date:   Fri, 29 Jan 2021 14:43:23 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>, arend@...adcom.com
Cc:     patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: crc8: Pointer to data block should be const

On 1/29/21 8:41 AM, Richard Fitzgerald wrote:
> crc8() does not change the data passed to it, so the pointer argument
> should be declared const. This avoids callers that receive const data
> having to cast it to a non-const pointer to call crc8().
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> ---
>  include/linux/crc8.h | 2 +-
>  lib/crc8.c           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

You need to Cc: someone to merge it, like Andrew Morton
or whoever scripts/get_maintainer.pl tells you.

Thanks.
-- 
~Randy